alanshaw/david

Outdated status should respect supported node versions

Open

#95 建立於 2015年12月28日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (962 star) (81 fork)batch import
help wanted

描述

Here is an example explaining the issue.

  • foo supports node version >= 0.10.0
  • foo depends on version 1.x.x of bar
  • bar version 2.0.0 is published and supports node version => 4.0.0
  • bar version 1.0.0 supports node version >= 0.10.0

David shouldn't show an outdated badge for foo, since foo is using the latest supported version of bar on the version of node that foo runs on.

Either that, or David should have an updated status for this special case.

貢獻者指南

技術棧
javascriptnodejs
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of npm semverreading David's source code
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate how David currently determines outdated status by examining the main logic in index.js. Understand how it queries npm registry and compares versions. The fix requires incorporating the node engine requirements from the package.json ( both the parent and child packages ) to avoid marking a dependency as outdated when the parent's node version cannot support the newer version. Look for functions that handle version comparisons and check the engines field in the package data.