aksonov/react-native-router-flux

Actions.pop always return true

Open

#3,337 建立於 2018年10月30日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (8,999 star) (2,112 fork)batch import
bughelp wanted

描述

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.4
  • react v16.2.0
  • react-native v0.53.3

Expected behaviour

In RNRF v4.0.0-bate25, Actions.pop return false if the sence is the first page, but 4.0.4 always return true.How do I tell if my stack is currently empty?

Actual behaviour

As above

貢獻者指南

技術棧
javascriptreact nativereact
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of React Native navigationFamiliarity with react native router flux APIBasic JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the Actions.pop implementation in the library's source code, likely in the core router file. The pop method should check if there is only one scene in the stack and return false in that case. Look for any recent changes that might have removed this check. Test with a minimal React Native app using the library and verify that Actions.pop returns false when navigation stack has only one scene.