akka/akka-http

empty Uri fragment ignored

Open

#3,859 建立於 2021年6月29日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)Scala (1,311 star) (598 fork)batch import
1 - triagedhelp wantedt:coret:model

描述

The Uri.withFragment function does not allow one to set an empty fragment, which is allowed by the IETF spec I believe, and by the Uri constructor, as shown:

import akka.http.scaladsl.model.Uri
import Uri.*

scala> val good = Uri("https",Authority(Host("example.com")),Path./("doc"),None,Some(""))       
val good: akka.http.scaladsl.model.Uri = https://example.com/doc#

scala> val noFrag = Uri("https",Authority(Host("example.com")),Path./("doc"),None,None)
val noFrag: akka.http.scaladsl.model.Uri = https://example.com/doc

scala> noFrag.withFragment("")
val res3: akka.http.scaladsl.model.Uri = https://example.com/doc

貢獻者指南

技術棧
無
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Scala basicsURI RFC knowledgeAkka HTTP source structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The issue is in the `withFragment` method of `Uri` class in Akka HTTP. The current implementation treats an empty string as no fragment, but the URI constructor allows empty fragment. To fix, examine `Uri.scala` around the `withFragment` method (likely in `akka http core/src/main/scala/akka/http/scaladsl/model/Uri.scala`). The fix should ensure that setting an empty fragment string results in a URI with an empty fragment, not `None`. Check the constructor logic for how fragment is stored and adapt `withFragment` accordingly. Also review the IETF URI spec (RFC 3986) to confirm empty fragment is allowed.