akka/akka-http

Replace ExecutionContextExecutor from scaladsl

Open

#2,598 建立於 2019年7月16日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Scala (598 fork)batch import
1 - triagedhelp wantedt:routingtechnical-debt

倉庫指標

Star
 (1,311 star)
PR 合併指標
 (平均合併 1天 10小時) (30 天內合併 2 個 PR)

描述

Especially, implicit ExecutionContextExecutor parameters should be replaced as they will never picked up (no one would provide such an implicit by default).

It seems, the ExecutionContext was changed to ExecutionContextExecutor in https://github.com/akka/akka/pull/19578 in an attempt to provide it to the javadsl.

I'd suggest:

  • We deprecate all methods that take an implicit ExecutionContextExecutor and replace them with ones that take an ExecutionContext
  • We need to decide how get an ExecutionContextExecutor out of an ExecutionContext where needed. We could either expect all instances to also be a ExecutionContextExecutor and WARN or fail otherwise, or we could wrap instances otherwise to provide the necessary Executor API for the javadsl side of things.
  • Not sure if we can do something about the very public API of scaladsl RequestContext.executionContext so maybe we need to keep it.

貢獻者指南