akka/akka-core

MetricsCollector.apply() does not report exceptions from custom collector creation

開放

#27,673 建立於 2019年9月10日

 (1 則留言) (0 個反應) (0 位負責人)Scala (3,547 個分叉)batch import
1 - triagedhelp wanted

倉庫指標

星標
 (13,277 顆星)
PR 合併指標
 (平均合併 8天 19小時) (30 天內合併 10 個 PR)

描述

When custom collector class is specified and fallback collector is allowed, MetricsCollector.apply() attempts to instantiate it in a TryNative. If it fails, it simply instatiates the fallback collector without reporting the problem. It should log the exception with stack trace.

We've discovered by accident that some of our non-critical metrics were not collected because of this --- without any indication in the logs.

貢獻者指南