akka/akka-core

resizer.enabled is confusing and undocumented

開放

#24,284 建立於 2018年1月11日

 (1 則留言) (0 個反應) (0 位負責人)Scala (3,547 個分叉)batch import
1 - triagedhelp wanted

倉庫指標

星標
 (13,277 顆星)
PR 合併指標
 (平均合併 8天 19小時) (30 天內合併 10 個 PR)

描述

I expected akka.actor.deployment.router.resizer.enabled = off would disable the resizer, but it doesn't appear to. I have to remove the entire section to disable. (Granted, it says so in the docs). But what is "enabled" for then?

from ktoso: some legacy reasons i guess

It's a bit confusing to have enabled = on (without any comments) in reference.conf since it suggests that you could use it to turn the resizer on/off.

If it doesn't do anything then the flag should probably be removed, or it should actually work. But barring that, a comment in reference.conf to clarify would help remove any confusion.

Also optimal-size-exploring-resizer.

貢獻者指南