akka/akka-core

PersistentFSMActor: Remove duplication between akka.actor.FSM and akka.persistence.fsm.FSM

Open

#18,154 建立於 2015年8月9日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Scala (13,277 star) (3,547 fork)batch import
1 - triagedhelp wantedt:persistence

描述

Currently akka.persistence.fsm.PersistentFSMActor inherits from akka.persistence.fsm.FSM - a clone of the original akka.actor.FSM with some Event Sourcing related changes in FSM's DSL. Possible ways to fix this: akka.persistence.fsm.FSM should either be derived from the original FSM or a common trait should be introduced - for example:

trait FSMCore {...}
trait FSM extends FSMCore {...}
trait EventSourcedFSM extends FSMCore {...}

貢獻者指南

技術棧
scala
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Scala programmingAkka framework basicsUnderstanding of FSM pattern
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the current code in akka.persistence.fsm.FSM and akka.actor.FSM. The goal is to create an intermediate trait (e.g., FSMCore) that contains common logic, and then have both FSM and EventSourcedFSM extend it. Focus on the duplication between the two FSM implementations and ensure backward compatibility. The proposed solution is outlined in the issue: extract a common FSMCore trait. Look at the existing API and internal methods to identify shared functionality.