ajaxorg/ace

Add support for numeric separator in Javascript and PHP

Open

#5,256 建立於 2023年7月15日

在 GitHub 查看
 (5 留言) (1 反應) (0 負責人)JavaScript (26,357 star) (5,252 fork)batch import
effort/smallfeature-requestgood first issuemode-requestp2

描述

Describe the feature

Please add a validation for the numeric number separator in Javascript: image

Use Case

https://github.com/tc39/proposal-numeric-separator

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

ACE version used

1.23.4

貢獻者指南

技術棧
javascriptphp
領域
frontenddeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScript syntaxPHP syntaxAce editor mode structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
This is a feature request to add validation for numeric separators (e.g., 1 000 000) in JavaScript and PHP within Ace. To implement, examine how numeric literals are currently tokenized in the JavaScript and PHP syntax mode files (likely under lib/ace/mode/). Using the TC39 proposal as reference, modify the regular expressions or tokenizer rules to allow underscores in numbers. Look at existing PRs or comments for guidance; one comment suggested using the 'go' mode as a reference. Coordinate with maintainers to ensure consistency with Ace's overall approach.
Add support for numeric separator in Javascript and PHP · ajaxorg/ace#5256 | Good First Issue