airbnb/rheostat

Aria-labels can't be added to slider buttons

Open

#273 建立於 2020年1月3日

在 GitHub 查看
 (3 留言) (9 反應) (0 負責人)JavaScript (1,688 star) (215 fork)batch import
enhancementhelp wanted

描述

For compliance, I need to add aria-labels to the slider buttons in an implementation like this one: http://localhost:9001/?path=/story/slider--rtl-multiple-handle. There doesn't seem to be a way to do this currently.

貢獻者指南

技術棧
javascriptreact
領域
frontendaccessibility
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic React knowledgeunderstanding of ARIA attributes
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue is to add aria labels to slider buttons in the rheostat component. Start by examining the slider component source code in the repository to identify where buttons are rendered. Look for existing prop handling for accessibility attributes. Check comments on the issue for any suggested approach. Consider adding a prop like `buttonAriaLabel` that can be passed to each handle. Ensure to update the component's TypeScript definitions if present. Test the change using the existing test suite and manual verification.