airbnb/rheostat

Snap points are not apparent while dragging

Open

#176 建立於 2018年7月6日

在 GitHub 查看
 (1 留言) (4 反應) (0 負責人)JavaScript (1,688 star) (215 fork)batch import
enhancementhelp wanted

描述

The handle currently snaps to a valid snap point at the end of a drag. While the handle is dragged, the control calls onValuesUpdated with all of the values between the snap points.

This behavior is a little odd because it's a little ambiguous what a valid snap point is until you stop dragging the handle. Snap points can be defined arbitrarily and it's weird to allow the UI to get updated (through onValuesUpdated) with any value that is not a valid snap point.

It would be beneficial if the snap points were reflected while the user was dragging the handle and not just after letting go.

FYI @ljharb

貢獻者指南

技術棧
javascriptreact
領域
frontendaccessibilitymobile
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic understanding of ReactFamiliarity with rheostat componentsJavaScript drag event handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the drag handling logic in rheostat, particularly how onValuesUpdated is called during drag. Locate the component files (likely in src/) such as Handle.js or the main slider component. Understand how snap points are defined and currently only applied at drag end. To implement this feature, modify the drag behavior to visually indicate snap points (e.g., highlight or show markers) as the user drags. Check any comments from maintainer @ljharb for additional guidance. Look at existing tests or examples to ensure the change does not break current functionality.