agrafix/Spock

Multiple file upload, but only one file in request body

Open

#143 建立於 2018年5月9日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Haskell (596 star) (54 fork)batch import
bughelp wanted

描述

Multiple file upload seems to not be handled correctly. If a user selects multiple files to upload on a file input field, such as the following, then the request body will contain only one file associated with the input field.

<input multiple name="files" id="files" type="file">

From a quick look at the code, maybe this part should use HM.fromListWith (<>) and a HashMap Text [UploadedFile]?

貢獻者指南

技術棧
無
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
HaskellSpock framework
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue is in the Spock web framework. The bug is in the file upload handling in Spock core/src/Web/Spock/Internal/Wire.hs at line 398. The suggested fix is to change the HashMap construction to use `HM.fromListWith (<>)` to collect multiple files under the same key. The code currently likely only retains one file per input field. If you are new to Haskell and Spock, first understand the `Wire.hs` module and how uploads are parsed. Then implement the change and test with multiple file selection.