adobe/react-spectrum

onCancel should fire in AlertDialog if Escape is pressed

Open

#1,773 建立於 2021年4月7日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)TypeScript (1,500 fork)auto 404
good first issue

倉庫指標

Star
 (15,634 star)
PR 合併指標
 (PR 指標待抓取)

描述

🐛 Bug Report (or maybe feature request?)

When adding an onCancel handler to an AlertDialog, it should fire if the dialog is closed via the Escape key.

See here for a repro: https://codesandbox.io/s/adoring-meadow-7cl4c?file=/src/App.js

Open the dialog, click Cancel, dialog will close, you'll see 'Canceled' in the console. Open the dialog, press Escape key, dialog will close, no 'Canceled' in the console.

貢獻者指南