addyosmani/critical

Remove query string from stylesheet path

Open

#551 建立於 2023年1月31日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (9,902 star) (457 fork)batch import
bughelp wanted

描述

In my simple PHP file I reference my stylesheet as follows:

<link rel="stylesheet" href="css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>"

When using the CLI, I get the following error:

Error: File not found: css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>

This could be addressed by automatically removing query strings like ?v before trying to access the file. After that it works as expected.

貢獻者指南

技術棧
javascript
領域
frontendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptunderstanding of file paths
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Investigate how the tool resolves file paths in the CLI. The issue suggests removing query strings (e.g., `?v=...`) from the href before accessing the file. Check the source code for where `css/style.css?v=...` is passed; likely in `lib/` or `src/`. Look for `path` or `fs` operations. The fix would involve stripping the query string using `url.parse` or string split. No linked PRs or comments.