[Bug]: filtering by "notes > has tags" matches all transactions when no '#' character is specified

(1 則留言) (0 個反應) (0 位負責人)JavaScript (603 個分叉)batch import

bughelp wanted

倉庫指標

星標: (7,129 顆星)
PR 合併指標: (平均合併 4天 15小時) (30 天內合併 165 個 PR)

描述

What happened?

In the transaction list, if you want to filter transactions that have a specific tag, you choose "Filter > Notes > has tags" and then you're expected enter the tag name like "#foo". However, if you forget to specify the hash character and simply enter "foo" into the text entry box, it doesn't actually filtere anything and it simply shows all transactions.

How can we reproduce the issue?

go to transaction list. Assume that the transaction list has some transactions with the tag '#foo' in their transaction notes
click "filter > Notes > has tags"
type 'foo' in text entry
the list shows all unfiltered transactions

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

貢獻者指南

研究方向: The bug is in the filter logic for 'has tags' in the transaction list. When a user types a tag without the '#' prefix, the filter fails. The fix likely involves automatically prepending '#' if missing, or validating input. Look for the filtering component, likely in the UI code under src/ or similar. Check the function handling the 'has tags' filter condition and adjust to handle the missing hash symbol.
技術棧: javascriptreact
領域: frontend
議題類型: 錯誤
難度: 2
預計時間: 1 小時以內
活動狀態: 新近可參與
清晰度: 清晰
前置要求: JavaScriptReact
新手友善度: 80