acdlite/redux-router

Router state duplication

Open

#59 建立於 2015年9月18日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)JavaScript (2,316 star) (215 fork)batch import
help wanted

描述

It seems to me that there is some overhead with keeping router state. When using redux-react-router we have router state in our app state and also in the component's props. So we have

this.props.router.location this.props.router.component this.props.router.params this.props.router.routes

this.props.params this.props.location this.props.history this.props.routes this.props.route this.props.routeParams

Is there any way to reduce number of props kept?

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactReduxReact Router
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the source code of redux router to understand how router state is passed as props to components. Look at the redux react router binding to see if there is a way to reduce duplication by using React Router's higher order components or Redux selectors. Review the comments in issue #59 for any proposed solutions.