WordPress/gutenberg

Native Image component includes outdated accessibility hint

Open

#45,124 建立於 2022年10月19日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)JavaScript (9,607 star) (3,893 fork)batch import
Good First IssueMobile App - i.e. Android or iOS[Block] Image[Block] Media & Text[Focus] Accessibility (a11y)[Type] Bug

描述

Description

When using a screen reader to navigate images in the native editor, an erroneous "Double tap and hold to edit" hint is read aloud. This discrepancy likely originates from https://github.com/WordPress/gutenberg/pull/40651.

Step-by-step reproduction instructions

  1. Add an Image or Media & Text block.
  2. Add media to the block.
  3. Enable Voice Over.
  4. Move focus to the image.

Expected behaviour

An accurate hint is read aloud, e.g. "Double tap to view larger."

Actual behaviour

An inaccurate hint is read aloud: "Double tap and hold to edit."

Screenshots or screen recording (optional)

https://user-images.githubusercontent.com/438664/196736195-90c75082-05e2-43dc-bdb4-19adf72e9b76.MP4

WordPress information

  • WordPress version: 6.1
  • Gutenberg version: 14.3.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Geologist

Device information

  • Device: iPhone SE
  • Operating system: iOS 16
  • WordPress app version: 1.84.0

貢獻者指南

技術棧
javascriptreactreact native
領域
accessibilityfrontendmobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic familiarity with React Nativeknowledge of accessibility labels
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Investigate PR #40651 that introduced the hint. Search the codebase for the string 'Double tap and hold to edit' likely in packages/components/src/image/index.native.js. The fix should update the hint to 'Double tap to view larger' or a similar appropriate string. Check if the hint is localized or defined as a constant.
Native Image component includes outdated accessibility hint · WordPress/gutenberg#45124 | Good First Issue