Testing: Add integration test which ensures that npm packages can be used with Node
#17,273 建立於 2019年8月30日
倉庫指標
- 星標
- (9,607 顆星)
- PR 合併指標
- (平均合併 12天 18小時) (30 天內合併 509 個 PR)
描述
This should prevent bugs like #17165 where a naked reference to window will crash if used in a SSR context where there's no window.
See more details in the comment from @jsnajdr https://github.com/WordPress/gutenberg/pull/17165#issuecomment-525193133:
In this case, the easiest TDD-style test would be to simply import
@wordpress/composein a Node.js environment without DOM. And it would fail.Neither
composenorcomponentspackages use thesideEffects: falseflag (although they would be a good fit IMO), so using anything fromcomposebundles the whole library.And the
windowcheck is a top-level statement in the module. We don't need to use or instantiate theuseReducedMotionhook at all to get a broken build.