Allow the PanelColorSettings to be visible if no colors and but with children · WordPress/gutenberg#12583

(6 留言) (0 反應) (0 負責人)JavaScript (9,607 star) (3,893 fork)batch import

Good First IssueNeeds Dev[Package] Components[Type] Enhancement

描述

Is your feature request related to a problem? Please describe. With the PanelColorSettings, if the color prop is empty, the entire panel stops rendering. However, if PanelColorSettings has children, they won't show anymore also if the color prop is empty. I expect that the panel would still show up if it has children even with no color options available.

Describe the solution you'd like The PanelColorSettings should only hide if there are no color options AND no children. Right now is only checks the number of color options.

Describe alternatives you've considered I tried creating my own PanelColorSettings component to address this, but it uses a lot of unexposed / private components.

貢獻者指南

技術棧: javascriptreact
領域: frontend
議題類型: feature
難度: 2
預計時間: 1-3 hours
活動狀態: fresh
清晰度: clear
前置要求: ReactJavaScriptWordPress/Gutenberg basics
新手友善度: 80
研究方向: Locate the PanelColorSettings component in the Gutenberg repository, likely in packages/components/src. Examine the component's render method where it currently returns null if there are no color settings. Modify the conditional to also check for the presence of children (props.children) and render the component if children exist, even if color settings are empty. Test the change by setting the colors prop to empty but passing children to ensure they render.