WordPress/gutenberg

Cover block: empty block shows as black box on frontend

Open

#10,854 建立於 2018年10月21日

在 GitHub 查看
 (7 留言) (1 反應) (0 負責人)JavaScript (9,607 star) (3,893 fork)batch import
Good First Issue[Block] Cover[Feature] Blocks[Priority] Low[Status] In Progress[Type] Enhancement

描述

Describe the bug If you insert a cover block and don't upload any image or video, it will appear as a black box in the frontend.

Expected behavior If the block in the backend is empty, I would expect the placeholder not to render any content.

Tested with Gutenberg 4.1 RC 1 + Twenty Seventeen as well as Twenty Nineteen.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactGutenberg block development
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue is that the Cover block renders a black box when no image or video is set. The fix should be in the Cover block's edit component, likely in `packages/block library/src/cover/edit.js`. Look for the condition that determines whether to render the placeholder or the media. The expected behavior is to render nothing (or a placeholder) when empty. Check the current implementation and add a conditional check to only render the media element if a media ID or URL is present.