VSCodeVim/Vim

Remove subclassing from actions.ts

Open

#519 建立於 2016年7月26日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)TypeScript (12,664 star) (1,271 fork)batch import
help wantedkind/refactorsize/M

描述

We have this pattern going on in actions.ts where, if we want to implement an action that's similar to another action, we make a new class that just extends the old class and reimplements what changed.

I am not a big fan of this. The main problem is that if someone changes the base class, it's not obvious at all that the subclasses could have been depending on the behavior of the base class.

I would like to refactor actions.ts so that no concrete actions extend from other concrete actions. This can be done in two steps.

  • For all actions that are synonyms (ctrl-[ and esc, for example), we need to make the keys variable accept a list of key sequences rather than just one.
  • For all actions that are not synonyms but actually have differing implementations (not sure how many of these we even have), I am ok with extending from a shared "abstract" base class.

貢獻者指南

技術棧
typescript
領域
developer experience
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptVSCode extension developmentclass inheritance concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue is about refactoring actions.ts to remove concrete subclassing. The first step (synonym actions) is already done. The remaining work involves identifying all concrete actions that extend other concrete actions and refactoring them to use a shared abstract base class. Examine the actions.ts file for current inheritance patterns and ensure that no concrete class extends another concrete class. Follow the pattern from step 1 and the maintainer's comments in the issue body.
Remove subclassing from actions.ts · VSCodeVim/Vim#519 | Good First Issue