VSCodeVim/Vim

Editor is undefined

Open

#3,033 建立於 2018年9月7日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)TypeScript (12,664 star) (1,271 fork)batch import
good first issuehelp wanted

描述

Describe the bug The property 'editor' can be undefined (see Screenshots section).

To Reproduce Steps to reproduce the behavior:

  1. Start VSCode
  2. Check Breakpoints > Promise Rejects and Breakpoints > Uncaught Exceptions
  3. Start my extension in debug mode (Debugger > Launch client). I believe, that can be reproduced with any extension, though it happened to me during development of mine plugin.
  4. If any file is opened after start, close all of them and start again.

Expected behavior The absence of the error.

Screenshots debugger

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 0.16.3
  • VSCode version: 1.27.1
  • OS: Ubuntu 16.04

Additional context

貢獻者指南

技術棧
typescript
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic TypeScriptVSCode extension API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the code at src/mode/modeHandler.ts line 1324 where `editor` is accessed without a null check. Review the context to understand when `editor` could be undefined, such as when no file is open. Add a guard clause to handle the undefined case, perhaps by returning early or providing a fallback. Test the fix by starting VSCode with no files open and triggering the debug steps described in the issue.