Core/SAI: SMART_ACTION_UPDATE_TEMPLATE and kill credit from updated entry
#24,702 建立於 2020年5月27日
倉庫指標
- Star
- (8,705 star)
- PR 合併指標
- (平均合併 14天 14小時) (30 天內合併 5 個 PR)
描述
Description:
If original creature loses big amount of health (70% or more) and then you force it to update entry, you will not receive kill credit after killing updated creature.
I have to notice that everything works fine in this script but not in the SAI https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Outland/zone_netherstorm.cpp#L336-L462 For tests: .q a 10190 .go c id 18879 damage the creature up to 70% health use the quest item kill the updated creature
Expected behaviour:
You must be awarded with kill credit even if original creature loses 99% of health.
Steps to reproduce the problem:
.q a 12516 .go c id 28068 .dam 40000 use quest item on the creature kill updated creature
Or apply #24703 .q a 10190 .go c id 18879 damage the creature up to 70% health use the quest item kill the updated creature
TrinityCore rev. 12679fdd080e 2020-05-27 16:03:53 +0200 (3.3.5 branch) (Win64, RelWithDebInfo, Static) Using SSL version: OpenSSL 1.1.1g 21 Apr 2020 (library: OpenSSL 1.1.1g 21 Apr 2020) Using Boost version: 1.72.0 Using MySQL version: 50730 Using CMake version: 3.17.2 Compiled on: Windows 6.3.9600 Automatic database updates are enabled for the following databases: Auth, Characters, World Worldserver listening connections on port 8085 Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1 MMAPs status: Enabled maps directory located in ./maps. Total size: 251987687 bytes vmaps directory located in ./vmaps. Total size: 658130721 bytes mmaps directory located in ./mmaps. Total size: 1997851292 bytes Using enUS DBC Locale as default. All available DBC locales: enUS Using World DB: TDB 335.20051