TheSpyder/rescript-webapi

Remove trailing _ from method and parameter names

開放

#29 建立於 2021年9月23日

 (0 則留言) (0 個反應) (0 位負責人)ReScript (38 個分叉)github user discovery
good first issue

倉庫指標

星標
 (159 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

In many cases, ReScript syntax is unambiguous enough that a trailing _ is no longer required in places it was for ReasonML and OCaml syntax. A codebase search for _: turns up quite a lot of them. Examples: https://github.com/tinymce/rescript-webapi/blob/ea9bd980f1b2b2d516e518f1f9c166feb1073f33/src/Webapi/Webapi__Blob.res#L10

https://github.com/tinymce/rescript-webapi/blob/253ba954381a78b57bad249ea83c1f5b6ab2b428/src/Webapi/Dom/Webapi__Dom__HtmlFormElement.res#L17

The compiler will signal when removing the underscore is not allowed, making this a mostly trivial change (but some tests would be nice)

貢獻者指南