Supervisor/supervisor

Eventlistener protocol "len" header changed in Supervisor 4

Open

#1,243 建立於 2019年5月23日

在 GitHub 查看
 (33 留言) (0 反應) (0 負責人)Python (7,941 star) (1,233 fork)batch import
eventshelp wanted

描述

@plockaby wrote comments of issue #1235:

Migrating from version 3 to version 4, my event listeners read from supervisor over stdin using a byte stream and then did the conversion to utf8 and chose to "backslashreplace" undecodable utf8 data. When I went to version 4 I expected to continue to get a byte stream that I could convert myself to whatever encoding I knew the data to be in. It was really unexpected to discover that supervisor was doing the conversion for me and then telling me the number of characters to read off of stdin and not the number of bytes.

cc: @vsajip

貢獻者指南

技術棧
python
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Knowledge of PythonUnderstanding of Supervisor event listener protocol
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate the change in the 'len' header from bytes to characters in Supervisor's event listener protocol. Review the pull request discussion at PR #1235 and the referenced issue #1235. Look at the supervisor/events.py or similar files where stdin reading and header parsing occurs. Determine if the conversion to characters is intentional or a bug, and consider adding a configuration option to preserve byte based behavior.