Supervisor/supervisor

Bad file descriptor during cleanup_fds

Open

#1,110 建立於 2018年6月13日

在 GitHub 查看
 (18 留言) (0 反應) (0 負責人)Python (7,941 star) (1,233 fork)batch import
help wanted

描述

I sometimes get (when quitting supervisor with CTRL+C) the following trace:

^C2018-06-13 22:32:21,219 WARN received SIGINT indicating exit request
2018-06-13 22:32:21,220 INFO waiting for web to die
2018-06-13 22:32:21,270 INFO stopped: web (exit status 0)
2018-06-13 22:32:21,270 INFO Closing socket tcp://0.0.0.0:8000
Exception ignored in: <bound method tail_f_producer.__del__ of <supervisor.http.tail_f_producer object at 0x7f599b85e2e8>>
Traceback (most recent call last):
  File "/home/florian/.local/lib/python3.6/site-packages/supervisor/http.py", line 649, in __del__
    self._close()
  File "/home/florian/.local/lib/python3.6/site-packages/supervisor/http.py", line 675, in _close
    self.file.close()
OSError: [Errno 9] Bad file descriptor

my supervisor config file:

[supervisord]
logfile = /tmp/supervisord.log

[inet_http_server]
port = 127.0.0.1:9001

[supervisorctl]
serverurl = http://127.0.0.1:9001

[rpcinterface:supervisor]
supervisor.rpcinterface_factory = supervisor.rpcinterface:make_main_rpcinterface

[fcgi-program:web]
# Patched gunicorn supporting fcgi-program: https://github.com/benoitc/gunicorn/pull/1809
command = python -m gunicorn.app.wsgiapp --reuse-port --workers 4 --bind fd://0 test:application
directory = %(here)s
socket = tcp://0.0.0.0:8000

I cannot yet reliably reproduce :/

貢獻者指南

技術棧
python
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
knowledge of Pythonfile descriptors
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the cleanup code in supervisor/http.py, specifically the tail f producer. close method and its interaction with socket closing. The bug is intermittent and occurs during shutdown. Look for potential race conditions where the file descriptor is closed before the del method is called. Consider adding error handling to ignore EBADF errors or ensuring proper ordering of cleanup.