SortableJS/Sortable

[bug] Can't cancel swap once an item has been hovered over

Open

#1,866 建立於 2020年7月15日

在 GitHub 查看
 (13 留言) (5 反應) (0 負責人)JavaScript (30,389 star) (3,731 fork)batch import
Swapenhancementgood first issue

描述

Describe the bug

When using the Swap plugin, it's impossible to cancel a swap once the swap threshold has been met for an item. You can't drag the item back to its original place to prevent a swap. This happens with or without the revertOnSpill: true option.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://sortablejs.github.io/Sortable/#swap
  2. Drag "Item 1" to hover over "Item 2", triggering Item 2 to get highlighted. Don't drop "Item 1", but instead try to prevent a swap by moving Item 1 back to its original place.
  3. See: It's not possible to prevent a swap.

Expected behavior

Dragging Item 1 back to its original place, or off of the list, should deactivate the swap.

Information

Sortable.version == 1.10.2

I didn't include a code sandbox since it's visible with Sortable.js's own Github site.

Thank you so much for your work on this library!

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic understanding of Sortable.js swap plugin
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the Swap plugin's event handling in the Sortable.js codebase. The issue is that once the swap threshold is met, the swap cannot be undone. Look at the `onDrag` or `onMove` callbacks in the plugin's source code, likely in `plugins/Swap.js`. Check if there is a condition that prevents reverting when `revertOnSpill` is true. The fix might involve allowing a cancellation of the swap when the dragged item returns to its original position or leaves the list.