SigNoz/signoz

Feat(FE): Global Time Visibility as per route

Open

#1,659 建立於 2022年10月25日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)TypeScript (16,037 star) (976 fork)batch import
good first issuehacktoberfest

描述

Is your feature request related to a problem?

Please describe. Right now to show the global header we are using routesToSkip , need to refactor the logic to display according to the route where this component is required

eg:

routes = ['/services','/service/:id','/trace','/logs','/dashboard/:dashboardId','/exceptions','/service-map']

Describe the solution you'd like

we can keep an array of routes in which the header needs to disable

Thank you for your feature request – we love each and every one!

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptBasic routing concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Examine the current implementation in `frontend/src/container/TopNav/index.tsx` that uses `routesToSkip`. Identify the routes where the global header should be shown instead of hidden. Refactor by switching to a whitelist approach, and test the changes with the mentioned routes like `/services`, `/trace`, etc.