SerenityOS/serenity

Everywhere: Audit usages of LexicalPath

Open

#21,450 建立於 2023年10月14日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C++ (33,171 star) (3,328 fork)batch import
help wanted

描述

Given directory tree

./
  a/
    b/
  e -> a/b

e/.. will refer to a, not .. However, since Directory::create lexically canonicalizes path, running Directory::create("e/..", Directory::CreateDirectories::No) will result in . being opened.

This results in inconsistency between our tar and GNU's tar if ran from . with arguments -cv e/.. -f /dev/null. I'm sure this is not the only place where we assume LexicalPath::canonicalize does not change what path refers to.

Although such resolution is not the most intuitive behavior, I think it should be fixed for the sake of consistency.

I am planning on addressing situation with paths altogether, so I made this issue mostly as a reminder for myself.

貢獻者指南

技術棧
cpp
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++file system concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue concerns inconsistent behavior of LexicalPath::canonicalize in SerenityOS, particularly when used with symlinks and parent directory references. The bug manifests in Directory::create where a path like 'e/..' is canonicalized to '.', leading to incorrect results compared to GNU tar. The fix likely requires auditing all usages of LexicalPath to ensure canonicalization does not change the target of paths with symlinks. The author has stated intent to address this, but no assignee or PR exists yet. Look at the LexicalPath implementation and all callers of canonicalize, especially in tar related code.