SerenityOS/serenity

PR Labeler: Does not properly relablel PRs

Open

#17,271 建立於 2023年2月2日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (33,171 star) (3,328 fork)batch import
help wantedtask list

描述

We added the handy PR labeler CI action, but it doesn't seem to add labels properly in the following cases:

  • When a review is submitted by someone other than the author, change the state from "needs review" to "waiting for author feedback"
  • When a review is approved, move the state to "community approved" or "maintainer approved" based on who did the approval.
  • When a PR is detected to have conflicts, add the "has conflicts" label
  • When changes are pushed, remove the "waiting for author feedback" label and add "needs review"

貢獻者指南

技術棧
github actionsshell
領域
ci cddevops
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
GitHub ActionsYAML scripting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the existing PR labeler workflow in .github/workflows. Identify the current logic for labeling based on reviews, approvals, conflicts, and pushes. Determine where the failures occur for the listed cases. Consider using a community labeler action or custom script to handle all states. Check if there are any configuration files or environment variables that control labeling behavior.