Semantic-Org/Semantic-UI-React

feat(Dropdown): support MenuItem and Button types

Open

#642 建立於 2016年10月6日

在 GitHub 查看
 (14 留言) (0 反應) (0 負責人)JavaScript (13,136 star) (4,065 fork)batch import
enhancementgood first issuehelp wanted

描述

Steps

I'm using a Dropdown as Menu.Item and noticed that the width of the menu item seems off. I checked the Semantic-UI docs (3rd example) and they are using an additional icon class for the menu item if the Dropdown only contains an Icon.

Expected

class="ui dropdown icon item"

Result

class="ui dropdown item"

Workaround

adding className='icon'as additional Dropdownprop

Testcase

http://codepen.io/Chlris-R3/pen/PGQbqZ

  • left: without icon class
  • right: using className='icon' as additional Dropdownprop

Is this a bug / missing feature / working as intended?

貢獻者指南

技術棧
reactjavascriptcss
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactSemantic UI React componentsJSX
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue requests that when a Dropdown is used as a Menu.Item, the component should automatically add the 'icon' class. Inspect the Dropdown component (likely in src/modules/Dropdown/Dropdown.js) and the Menu.Item component (src/collections/Menu/MenuItem.js) to understand how className is constructed. The fix likely involves checking if the Dropdown contains only an Icon and adding the 'icon' className accordingly, similar to Semantic UI's behavior.