Semantic-Org/Semantic-UI-React

Dropdown doesn't close when placed inside of Checkbox component

Open

#4,036 建立於 2020年8月15日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)JavaScript (13,136 star) (4,065 fork)batch import
bughelp wanted

描述

Bug Report

Steps

  1. Click on dropdown
  2. Click on one of the options

Expected Result

The dropdown menu should close

Actual Result

It remains open until you click on one of the options one more time or click outside of the menu

Version

1.2.0

Testcase

https://codesandbox.io/s/vigorous-ives-l0qwm?file=/example.js

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic React knowledgeUnderstanding of event propagation
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate event handling in Dropdown and Checkbox components. Look at https://github.com/Semantic Org/Semantic UI React/blob/master/src/modules/Dropdown/Dropdown.js and https://github.com/Semantic Org/Semantic UI React/blob/master/src/modules/Checkbox/Checkbox.js to understand click propagation. The issue may be related to event.stopPropagation() interfering with dropdown close logic. Test the behavior in the provided CodeSandbox and identify where the click event is being swallowed.
Dropdown doesn't close when placed inside of Checkbox component · Semantic-Org/Semantic-UI-React#4036 | Good First Issue