Semantic-Org/Semantic-UI-React

Rework TransitionablePortal callbacks for consistency

Open

#2,423 建立於 2018年1月10日

在 GitHub 查看
 (9 留言) (0 反應) (0 負責人)JavaScript (13,136 star) (4,065 fork)batch import
bughelp wanted

描述

Steps

  1. Create a controlled <TransitionablePortal />
  2. Toggle the open prop from false to true
  3. Trigger a close with ESC or click outside

Expected Result

  1. On prop change to open, the onOpen callback should not be called. This is a programmatic prop change, not a trigger click.
  2. When a close event is triggered, the onClose callback should be called before starting the transition as the user may choose to disregard the close request.

Actual Result

  1. On prop change to open, onOpen is called at the beginning and end of the open transition
  2. When a close event is triggered, the onClose callback is called after the onHide callback. There is no way to handle the close request and ignore it.

See the test case for proposed fixes.

Version

0.77.2

Testcase

https://codesandbox.io/s/rj8qv1yl2o

貢獻者指南