Semantic-Org/Semantic-UI-React

Dropdown: when options contain custom elements, setState in onChange leads to mismatch of 'active' and 'selected' option

Open

#2,296 建立於 2017年11月6日

在 GitHub 查看
 (14 留言) (2 反應) (0 負責人)JavaScript (13,136 star) (4,065 fork)batch import
bughelp wantedstale

描述

Steps

I want to setState() within onChange of the Dropdown and have custom elements within the options like so:

const options = [ { value: "1",
                    content: <span>a</span> 
                              }, ... ];

Expected Result

  1. The selected option should be active and selected

  2. The state should be set and the dropdown should change its value. The content of the option <span>a</span> should appear in the dropdown.

Actual Result

  1. The state is set as expected. The selected option is set to active, the previously selected option is kept as selected. => Selected and active do not match the same option anymore

  2. The content does not appear in the dropdown

If text is used instead of content

  1. The selected option is set to active, the previously selected option is kept as selected. => Selected and active do not match the same option anymore

  2. The content does appear in the dropdown

Questions: What should I use, text or content for this case? How to solve the mismatch?

Version

0.76.0

Showcase https://codesandbox.io/s/pp0w7wrn7q

Partially solved here: https://github.com/Semantic-Org/Semantic-UI-React/pull/2252

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
basic React knowledgeunderstanding of Semantic UI React Dropdown
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the Dropdown component's handling of 'active' and 'selected' states when options contain custom React elements. The issue and referenced PR #2252 suggest a mismatch occurs when setState is called in onChange. Examine the source code in the Dropdown component, particularly the onChange handler and how selectedIndex and activeIndex are updated. Also review the sandbox provided in the issue to reproduce the bug. Consider whether using 'text' vs 'content' is recommended and ensure that custom elements are properly rendered in the dropdown trigger.