SSENSE/vue-carousel

Feature request: Use style classes instead of inline styles

Open

#48 建立於 2017年4月19日

在 GitHub 查看
 (4 留言) (11 反應) (0 負責人)JavaScript (1,705 star) (513 fork)batch import
featurehelp wanted

描述

There're a few component options regarding styles such as paginationActiveColor, paginationPadding, etc. Since they are rendered as inline styles, it is hard to override them with CSS classes. It's better to set CSS classed for these elements. What do you think?

貢獻者指南

技術棧
vuejavascript
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic VueCSS knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Look at the current implementation of the carousel component, likely in a .vue file. Identify all props like `paginationActiveColor`, `paginationPadding` that set inline styles. Propose a mapping to CSS classes and consider how to allow user overrides. Review any existing comments or linked issues for design preferences.
Feature request: Use style classes instead of inline styles · SSENSE/vue-carousel#48 | Good First Issue