SSENSE/vue-carousel

Bug: Adjustable height is broken on both Firefox and IE11

Open

#412 建立於 2019年3月29日

在 GitHub 查看
 (8 留言) (1 反應) (0 負責人)JavaScript (1,705 star) (513 fork)batch import
buggood first issuehelp wanted

描述

Bug Report

Current Behavior When using adjustable height, Firefox seems to present the carousel as having a height of only 48. If you click on the carousel after it loads, it will instantly resize to the proper height.

Input Code and steps to reproduce

  • set :adjustableHeight="true"
  • refresh

Expected behavior/code The carousel height should initialize at the height of the first item. It works in Chrome but in FF/IE11 it initializes at 24 or 48 height.

Environment

  • Browsers: Firefox / IE11
  • OS: OSX 10.14.3

Possible Solution After debugging it looks like it has something to do with getCarouselHeight().

貢獻者指南

技術棧
vuejavascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Vue basicsbrowser debugging
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Examine the `getCarouselHeight()` function in the Vue carousel component to understand how it calculates height on initial load. Use browser dev tools to compare behavior in Chrome vs Firefox/IE11. The issue notes that clicking after load fixes the height, suggesting a timing or rendering issue. Check if there are any differences in how the browser reports element dimensions when the component mounts.
Bug: Adjustable height is broken on both Firefox and IE11 · SSENSE/vue-carousel#412 | Good First Issue