SSENSE/vue-carousel

Bug: pageChange event gives NaN sometimes with mouse drag

Open

#408 建立於 2019年3月26日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (1,705 star) (513 fork)batch import
buggood first issuehelp wanted

描述

Bug Report

Current Behavior On mouse drag on the last slide, sometimes pageChange event gives NaN while remaining on the same slide where mouse was dragged upon and after that carousel becomes non-operational on mouse drag(slides do not move at all).

Did not face this issue with custom navigation buttons however.

Input Code and steps to reproduce Attaching screenshot of console log, where pageChange event handler logs the page number.

Screen Shot 2019-03-26 at 6 51 42 PM

Expected behavior/code pageChange event shouldn't be triggered, if there is no slide change at all.

Babel Configuration (.babelrc, package.json, cli command)

貢獻者指南

技術棧
javascriptvue
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic Vue.js knowledgeUnderstanding of mouse eventsCarousel component logic
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the pageChange event emission in the carousel component. The issue occurs during mouse drag on the last slide. Review the drag handling logic and ensure that the page index is only emitted when a slide change occurs, not on every drag movement. Check the calculation of the page index to prevent NaN values. Look at the component's event handlers and the page update mechanism in files like Carousel.vue or similar.