SFTtech/openage

Trigger reconfigure when git commit hash changes

Open

#381 建立於 2015年9月15日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Python (12,130 star) (1,135 fork)batch import
area: buildsystemgood first issueimprovementjust do it

描述

When the value of git describe changes, we should trigger a reconfigure when typing make. This ensures the version generated to config.h matches with the actual repository version.

The "dirty" solution would be checking for the version each time, something better would be a update watch on some file in ./.git/, but maybe you have a better idea how cmake may detect a changed HEAD efficiently.

貢獻者指南

技術棧
ccpp
領域
build system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate the current CMake build system in openage, specifically how `git describe` is used to generate version information in `config.h`. Look for existing cmake functions that compute the version and where they are invoked. Then implement a dependency on `.git/HEAD` or a similar file to trigger reconfiguration when the commit hash changes. Consider using CMake's `configure file` with `CONFIGURE DEPENDS` or adding a custom target that depends on the git file. Review the comments on the issue for any alternative suggestions.