SFTtech/openage

Pure fixed-point math functions

Open

#1,543 建立於 2023年9月17日

在 GitHub 查看
 (13 留言) (0 反應) (0 負責人)Python (12,130 star) (1,135 fork)batch import
good first issuelang: c++nice new thing ☺

描述

Required Skills: C++

Difficulty: Easy

We should add additional math operations to our fixed-point implementation, so that all calculations can be done purely deterministic. The fpm library already has these operations and could be used as an inspiration.

Important here: These operations must not use any floating point arithmetic for the calculation. They must receive fixed-point values as input and must also return a fixed-point value. This means std library calculations should not be used for solving this issue.

Interesting for us:

  • sqrt
  • min
  • max
  • abs
  • hypot
  • atan2

Nice to have:

  • sin
  • cos
  • tan
  • pow
  • log

Further Reading

貢獻者指南

技術棧
cpp
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++fixed point arithmeticfpm library understandingopenage fixed point header
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Study the existing fixed point.h in libopenage/util. Understand how sqrt, min, max, abs, hypot are implemented (they are already done). Then examine the fpm library's implementation of atan2 and the nice to have functions. Implement the functions ensuring no floating point arithmetic, and add tests and documentation. Pay attention to potential overflow and precision issues.
Pure fixed-point math functions · SFTtech/openage#1543 | Good First Issue