SFTtech/openage

Parse nyan API objects in converter instead of hardcoding them

Open

#1,313 建立於 2020年9月7日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)Python (12,130 star) (1,135 fork)batch import
area: assetsgood first issuelang: cythonlang: python

描述

Required skills: Python, Cython, nyan, maybe C++

Difficulty: Medium

Currently, the asset converter stores the openage nyan API as hardcoded nyan objects. It would be much better if the converter could read the API objects from the filesystem with a parser. There would be two ways to do this. Either we implement a new Python parser for nyan or we extend libnyan's already existing C++ parser with a Python interface (related issue in nyan repository).

Further reading:

貢獻者指南

技術棧
pythoncpp
領域
backendtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonC++openage converter architecturenyan API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Start by studying the current hardcoded API objects in openage/convert/service/read/nyan api loader.py. Then review the converter architecture documentation at doc/code/converter/architecture overview.md to understand how the converter loads nyan objects. Next, consider the two approaches: either implement a Python parser for nyan or extend libnyan's C++ parser with a Python interface, referencing the related nyan issue #64. The chosen approach should be discussed with maintainers before implementation.