RipMeApp/ripme

Implement subdirectory sanitisation

Open

#16 建立於 2017年7月9日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Java (3,524 star) (640 fork)batch import
enhancementhelp wanted

描述

The addURLToDownload method in AbstractRipper should have sanitisation implemented for sub directories. It's currently possible to pass invalid characters and have the directory creation fail. This is particularly an issue on Windows platforms.

Another side effect of no sanitisation is that slashes in the directory name create further subdirectories.

貢獻者指南

技術棧
java
領域
clidesktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Javafile I/Oregular expressions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Examine the addURLToDownload method in AbstractRipper.java. Implement a sanitization function that removes or replaces invalid filesystem characters (e.g., <, >, :, ", /, \, |, ?, *) from subdirectory names. Consider using platform specific filename checks like File.separatorChar or a regex pattern. Look at any existing test files for ripper methods and consider adding a unit test for the sanitization logic. Check the issue comments for any proposed solutions or discussions.