ReactiveX/rxjs

Rename window to windowWith

Open

#5,296 建立於 2020年2月6日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)TypeScript (31,024 star) (3,007 fork)batch import
help wanted

描述

We need to deprecate window, because it was a really dumb name, and rename it to windowWith or the like. I suggest windowWith just out of the spirit of concatWith and mergeWith renames... But I'm open to suggestions.

Related: https://github.com/ReactiveX/rxjs/issues/3788

貢獻者指南

技術棧
typescript
領域
api
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
TypeScriptrxjs operators knowledgegit
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue is to rename the `window` operator to `windowWith` following the pattern of `concatWith` and `mergeWith`. There is a linked discussion in issue #3788. The assignee should review all usages of `window` in the source code, including tests and documentation. The new name needs to be agreed upon; the maintainer suggested `windowWith` but open to suggestions. After renaming, the old `window` should be deprecated and re exported for backward compatibility.