Qix-/color

lighten and darken should be absolute

Open

#53 建立於 2015年2月16日

在 GitHub 查看
 (18 留言) (13 反應) (0 負責人)JavaScript (4,637 star) (316 fork)batch import
bughelp wantedpr welcome

描述

Hey,

in LESS and SASS the darken nand lighten function increase by an absolute amount. Example here: https://github.com/less/less.js/blob/fb5280f16f124e5062634a22be2f3c99e650d0a4/lib/less/functions/color.js#L163

This is a bit confusing because in color.js e.g. `color('#000000').lighten(1)' is still black.

I am not sure though if it would be better to change the function or create a new one like lightenAbsolute.

Best, Finn

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptcolor theory basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the current lighten and darken functions in the color library's source code (likely in `lib/color.js`). Review the issue comments (18 so far) for discussion on whether to modify existing functions or add new ones like `lightenAbsolute`. Consider the behavior of similar functions in LESS and SASS as referenced in the issue body (link to less.js line). Determine which approach the maintainers prefer and implement accordingly.