QAC-Portal/QA-Portal

Slightly Refactor Skills - CV api

開放

#183 建立於 2019年12月18日

 (2 則留言) (0 個反應) (0 位負責人)Java (5 個分叉)auto 404
Low PriorityUIgood first issuejava

倉庫指標

星標
 (2 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Currently in the CV api, under CvVersion.java, a person's skills are initialised as type List<Skills>.

However, Skills itself is an object made up of a list of skills. It's my understanding that everything can actually be contained within one Skills object, rather than a list of them (a list of lists).

This issue would involve:

  • changing the allSkills variable in CvVersion to be of type Skills rather than List<Skills>

  • making sure nothing breaks in the process

  • rewriting the few CV api tests that refer to the allSkills variable

貢獻者指南