PythonCharmers/python-future

newbytes is unable to handle a generator as a parameter

Open

#288 建立於 2017年6月21日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)Python (1,172 star) (327 fork)batch import
0.20bughelp wanted

描述

After only checking that the parameter is Iterable, newbytes then checks the parameters len(). https://github.com/PythonCharmers/python-future/blob/39a066ed8c29a0b3a32adac2ffd407119fe9ea6d/src/future/types/newbytes.py#L106

https://repl.it/IwSF/2

print(repr(bytes.newbytes(x for x in range(0))))

Traceback (most recent call last):
  File "main.py", line 4, in <module>
    print(repr(bytes.newbytes(x for x in range(0))))
  File "/home/runner/bytes.py", line 103, in __new__
    if len(args[0]) == 0:
TypeError: object of type 'generator' has no len()

Including a check for Sized as well avoids this.

if isinstance(args[0], Sized) and len(args[0]) == 0:

https://repl.it/IwSF/1

貢獻者指南

技術棧
python
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Python basicsUnderstanding of iterables
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The bug is in `newbytes. new ` in `src/future/types/newbytes.py` around line 106. The code currently checks `len(args[0])` without confirming the argument supports `len()`. Generators are iterable but not sized, causing a `TypeError`. The fix is to add an `isinstance(args[0], Sized)` check before calling `len()`. You'll need to import `Sized` from `collections.abc` (or `collections` depending on Python version). Review the existing imports and modify the condition accordingly.