PostHog/posthog

Add pageleave warning to Feature Flags edit page if changes are not committed

已關閉

#5,187 建立於 2021年7月17日

在 GitHub 查看貢獻者指南
 (19 則留言) (0 個反應) (1 位負責人)Python (988 個分叉)batch import
enhancementfeature/feature-flagsgood first issueteam/feature-flags

倉庫指標

星標
 (16,704 顆星)
PR 合併指標
 (平均合併 17小時 29分鐘) (30 天內合併 995 個 PR)

描述

Is your feature request related to a problem?

It is way too easy to navigate away from the Feature Flags edit page without pressing "Save", losing all changes. I have done it probably a dozen times.

Describe the solution you'd like

Longer term, any changes to filter criteria should auto-save. But because this will probably require extra testing and implementation time, for now a browser message like "Are you sure? Changes may not be saved" would suffice.

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

貢獻者指南

研究方向
Look at the Feature Flags edit page component (likely in frontend/src/scenes/FeatureFlags/FeatureFlagsEdit.tsx). Add a beforeunload event listener that triggers when there are unsaved changes. Ensure the warning only shows when form is dirty. Review existing patterns for unsaved changes warnings in other edit pages in the codebase for consistency.
技術棧
typescriptreactcss
領域
frontend
議題類型
功能
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 小時
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
較久未更新
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
清晰
前置要求
ReactTypeScriptPostHog frontend conventionsbrowser event handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75