PostHog/posthog

group flags that target groups should have default insights that only show `$feature_flag_called` events with groups associated with them

Open

#39,135 建立於 2025年10月4日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Python (16,704 star) (988 fork)batch import
good first issueteam/feature-flags

描述

right now, we create default insights for feature flags, but if a feature flag targets groups, we should tailor that default insight to only show $feature_flag_called events that have groups set on them, since otherwise these events don't really evaluation traffic to this flag (i.e. it can make the rollout percentages seem confusing since the amount of false events (just bc there are no groups) will be way larger than expected)

Folks have been confused about this: https://posthog.slack.com/archives/C075EH38BR8/p1759134575502819

貢獻者指南

技術棧
pythonpostgresql
領域
backendanalytics
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of PostHog feature flagsFamiliarity with default insights creationKnowledge of event properties filtering
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue is to modify the default insight creation for feature flags that target groups. Look into how default insights are generated for feature flags (likely in plugin or insight creation code) and add a filter to only include $feature flag called events that have a 'groups' property. The Slack thread referenced (C075EH38BR8) may contain further details. Check the feature flag model and the default insight generation logic.
group flags that target groups should have default insights that only show `$feature_flag_called` events with groups associated with them · PostHog/posthog#39135 | Good First Issue