PostHog/posthog

Feature Flag Hash Key Overrides table can grow out of control

Open

#16,885 建立於 2023年8月2日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Python (16,704 star) (988 fork)batch import
backlogbugfeature/feature-flagsgood first issueteam/flags-platform

描述

Bug description

The hashkeyoverrides table can grow seriously out of control because it keeps all rows for stale flags. We cascade delete, but since flags are soft deleted, this table doesn't clean itself up automatically, which makes it hard to keep the size manageable

Additional context

We should run a nightly/weekly job , or whenever a flag is deleted, to remove stale rows from this table.

Thank you for your bug report – we love squashing them!

貢獻者指南

技術棧
pythonpostgresql
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Django ORMdatabase cleanup strategies
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requires implementing a cleanup mechanism for the hashkeyoverrides table. Currently, flags are soft deleted but the overrides table retains rows. A scheduled job (e.g., using Celery) should delete rows where the associated flag is soft deleted. Alternatively, a post delete hook could be added. Review the existing model definitions in posthog/models/feature flag.py and the soft deletion logic. Ensure the job is idempotent and efficient for large tables.