PointCloudLibrary/pcl

[custom] Remove empty destructors and constructors

Open

#4,283 建立於 2020年7月20日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)C++ (9,023 star) (4,506 fork)batch import
effort: lowgood first issuekind: todo

描述

This issue is to split PR #4249 into smaller pieces.

Per @SergioRAgostinho

With destructors I use the following policy:

if your class defines virtual methods which it defines (literally defining, not overriding), I explicitly default it. The compiler throws warnings telling if of your class has virtual methods but the destructor is not virtual.

If a class has empty / default destructors I just remove those lines of code. If the destructor is not implicitly generated you'll get a compiler error, so there's no chance you'll mess up.

For constructors: remove all default constructors unless there's a user defined (non-default) constructor.

From @kunaltyagi: https://godbolt.org/z/8f99dG

貢獻者指南