PointCloudLibrary/pcl

Bad info in pkgconfig file

Open

#4,240 建立於 2020年7月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C++ (9,023 star) (4,506 fork)batch import
effort: lowgood first issuekind: bugkind: todo

描述

Just installed via All-In-One-Installer and wanted to point out that all of the pkgconfig .pc files installed have the wrong prefix path, it appears to be a relic of whoever builds the all-in-one-installer where their install prefix is set. The installer suggested to install into C:/Program Files/PCL 1.11.0 but wherever you install it, the pkgconfig files will always point to C:/Program Files/PCL image

I use PCL as an external dependency in another project I know how to get this working with the pkgconfig prefix issue, so I don't exactly need help. Just more a comment on what might give some people issues.

Originally posted by @WargodHernandez in https://github.com/PointCloudLibrary/pcl/issues/4069#issuecomment-652173534

貢獻者指南

技術棧
cpp
領域
build systemtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
CMake basicspkg configunderstanding of installation paths
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Locate the CMake configuration that generates the pkg config files (likely in CMakeLists.txt or a cmake module). Identify where the prefix path is hardcoded. Check the all in one installer scripts for any override. The fix should dynamically set the prefix based on the install prefix variable. Review the existing issue comments for any additional context.