PointCloudLibrary/pcl

Review casts in PCL

Open

#4,230 建立於 2020年6月26日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)C++ (4,506 fork)batch import
effort: higheffort: lowgood first issuehelp wantedkind: todo

倉庫指標

Star
 (9,023 star)
PR 合併指標
 (平均合併 8天 7小時) (30 天內合併 3 個 PR)

描述

Context

With the migration to index_t, PCL will soon have some unneeded casts which should be removed

Describe the solution you'd like

Each cast needs to be reviewed and removed if it's unneeded. A non-exhaustive list of such situations:

  • assigning index_t to width
  • assigning size_t to Indices

Additional context

This will require significant help from others since the scope is wide, but the issue is not hard at all. To get an idea of the scale, please check the occurrence of static_cast via:

grep '\s*static_cast' * -nrH | grep -v '<float>' | grep -v 'cast<\S*\*\s*>' | wc -l

Note: this doesn't count C style casts

(High effort for total change, low for effort needed for piece-meal contributions)

貢獻者指南